Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (723ba1e) to head (c3061e8).

@@            Coverage Diff            @@
##              main     #1262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12681     12681           
=========================================
  Hits         12681     12681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenFordTytherington Didn't we at some point discuss just directly implementing QObjectExt for anything that is Upcast<QObject>, e.g.:

impl QObjectExt for T where T: Upcast<QObject> {
}

That way we don't need another trait 🤔

We should then however make sure to move all methods from QObject into QObjectExt (even dump_object_info)

Just attempted to implement it for all these upcasting types for a bit, and the main problem is that now QObject upcasts to QObject, so we get a conflicting impl. I think this is initially why we went for a separate trait, and a blanket impl there, since my_obj.as_qobject().method() isn't too bad, compared to being able to do my_obj.method()

Why would we get a conflicting impl?
We no longer need to manually impl QObjectExt for QObject, as it will impl QObjectExt it via the auto-trait impl, right?